Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate trusted visor functionality #434

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Automate trusted visor functionality #434

merged 5 commits into from
Jul 22, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Jul 8, 2020 •
edited
Loading

Did you run make format && make check? Not yet

Fixes #431

Changes:

  • Register trusted visor in service discovery

How to test this PR:

  • Append "public_trusted_visor": true to visor's config that is going to be tested
  • Run integration env
  • If the visor is available from the internet, Sent request to register visor as public trusted followed by no errors would appear in logs; otherwise, the error Unable to register visor as public trusted as it's unreachable from WAN would appear.
  • If the visor is available from the internet, it should appear here: http://service.discovery.skywire.cc/api/services?type=visor

@nkryuchkov nkryuchkov requested review from evanlinjin, Darkren and jdknives and removed request for evanlinjin and Darkren July 13, 2020 13:47
@nkryuchkov nkryuchkov marked this pull request as ready for review July 13, 2020 13:47
@nkryuchkov nkryuchkov closed this Jul 14, 2020
@nkryuchkov nkryuchkov deleted the feature/automate-trusted-visor branch July 14, 2020 17:44
@nkryuchkov nkryuchkov restored the feature/automate-trusted-visor branch July 14, 2020 18:04
@nkryuchkov nkryuchkov reopened this Jul 14, 2020
@nkryuchkov nkryuchkov force-pushed the feature/automate-trusted-visor branch from 277fbae to bd11226 Compare July 15, 2020 11:43
Darkren
Darkren approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jdknives jdknives merged commit 0217c90 into skycoin:develop Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

@Darkren Darkren Darkren approved these changes

@evanlinjin evanlinjin Awaiting requested review from evanlinjin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkryuchkov @Darkren @jdknives